I’ve been having problems for years where my iPhone would have no space left, yet seemingly actually have space left. I’ve always felt like it was an iCloud photos library problem. So I finally downloaded originals to my Mac and I am now convinced Photos is the problem.